bobmatnyc avatar

Test Quality Inspector

This is a framework for inspecting test suites to find worthless assertions, missing edge cases, and gaps in coverage. It walks through example tests and flags things like "assert user" (which passes with corrupt data), missing negative test cases, and tests that don't actually verify persistence or state changes. The inspection reports show concrete rewrites with proper assertions, fixtures, and error case handling. Use this when reviewing PRs or auditing your own test code to catch tests that look fine but don't actually validate behavior. The examples focus on authentication flows, but the patterns apply to any domain where your tests need to prove something instead of just exercising code paths.

skills.sh installs
376
GitHub stars
79
last updated
Aug 21, 2026

Install

$ npx -y skills add bobmatnyc/claude-mpm-skills --skill test-quality-inspector --agent claude-code

Installs into .claude/skills of the current project.

Files

Example Test Inspection Report

Scenario: User Registration Feature

Engineer's Test Suite

# test_user_registration.py

def test_user_creation():
    """Test user creation"""
    user = create_user("test@example.com", "password123")
    assert user

def test_login():
    """Test login"""
    user = create_user("test@example.com", "password123")
    result = login("test@example.com", "password123")
    assert result

def test_duplicate_email():
    """Test duplicate email"""
    create_user("test@example.com", "password123")
    user2 = create_user("test@example.com", "password456")
    assert user2

QA Inspection Report

Test 1: test_user_creation()

Claimed Intent: Test user creation Actually Tests: Object instantiation only

Issues Found

🔴 CRITICAL: Worthless Assertion

assert user  # Line 5
  • Would pass with corrupt data
  • Would pass with wrong email
  • Would pass with invalid password hash
  • Would pass if database save failed

Mental Debug: User object with garbage data would pass this test.

Sponsors

Details

Repository
github.com/bobmatnyc/claude-mpm-skills
Categories
Testing & QA, Code Review & Quality
First seen
Jun 3, 2026

More from bobmatnyc/claude-mpm-skills

All 158
1galaxy-dawn avatarwebapp-testinggalaxy-dawn/claude-scholarToolkit for interacting with and testing local web applications using Playwright. Supports verifying frontend functionality, debugging UI behavior, capturing br375skills.sh installs
2owainlewis avatartddowainlewis/blueprintTest-first variant of implement: understand the desired behavior, write a failing test, make it pass, then simplify.371skills.sh installs
3davila7 avatarwebapp-testingdavila7/claude-code-templatesToolkit for interacting with and testing local web applications using Playwright. Supports verifying frontend functionality, debugging UI behavior, capturing br370skills.sh installs
4bobmatnyc avatarjest-typescriptbobmatnyc/claude-mpm-skillsJest with TypeScript - Industry standard testing framework with 70% market share, mature ecosystem, React Testing Library integration354skills.sh installs
5decebals avatartest-qualitydecebals/claude-code-javaWrite high-quality JUnit 5 tests with AssertJ assertions. Use when user says "add tests", "write tests", "improve test coverage", or when reviewing/creating tes336skills.sh installs
6secondsky avatarbun-test-mockingsecondsky/claude-skillsUse for mock functions in Bun tests, spyOn, mock.module, implementations, and test doubles.335skills.sh installs